chore(interop): Change structopt to clap #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tottoto
force-pushed
the
change-structopt-to-clap
branch
from
024dee6
to
8baa4c9
Compare
tottoto
force-pushed
the
change-structopt-to-clap
branch
from
8baa4c9
to
a45b819
Compare
djc
approved these changes
Jan 12, 2022
|
Did something happen to structopt? Whats the motivation here? |
|
clap 3 came out which brings structopt (which used clap under the hood) into the clap crate. So this is basically a massively modernized version of structopt, which works the same but has a bunch of refinements and also relies on clap 3 under the hood instead of clap 2. AFAICT structopt/clap 2 are a dead end. |
|
Yep! At embark we've moved all our internal stuff to clap as well. |
LucioFranco
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Change structopt to clap version 3.
Solution
Change structopt to clap version 3.