Fix URI fragment decoding in instance get() #55

hudlow · 2024-03-09T21:53:41Z

Fixes #54.

jdesrosiers

Thanks for finding and fixing this issue! I appreciate that you put enough care into this that you found the uriFragment function and used it.

I've made a couple suggestions just to conform to the code style I prefer for JSON.

annotations/tests/pointer.json

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>

Fix URI fragment decoding in instance get()

7bfac3b

jdesrosiers requested changes Mar 11, 2024

View reviewed changes

annotations/tests/pointer.json Outdated Show resolved Hide resolved

annotations/tests/pointer.json Outdated Show resolved Hide resolved

annotations/tests/pointer.json Outdated Show resolved Hide resolved

JSON formatting per code review

b6de91f

Co-authored-by: Jason Desrosiers <jdesrosi@gmail.com>

hudlow requested a review from jdesrosiers March 11, 2024 02:59

jdesrosiers approved these changes Mar 11, 2024

View reviewed changes

jdesrosiers merged commit d016391 into hyperjump-io:main Mar 11, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix URI fragment decoding in instance get() #55

Fix URI fragment decoding in instance get() #55

hudlow commented Mar 9, 2024

jdesrosiers left a comment

Fix URI fragment decoding in instance get() #55

Fix URI fragment decoding in instance get() #55

Conversation

hudlow commented Mar 9, 2024

jdesrosiers left a comment

Choose a reason for hiding this comment