Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keyword descriptions to meta schemas #57

Merged
merged 1 commit into from Apr 24, 2024

Conversation

mabagoury
Copy link

The $id description is only added for now to see if updating the node module would make things work correctly.

Copy link
Collaborator

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little wary of the maintenance requirements of some of the more elaborate descriptions. Let's keep it to relatively simple descriptions. We can include a link to learnjsonschema.com (which I noticed is where you're getting your descriptions anyway) for more information.

draft-04/schema.js Outdated Show resolved Hide resolved
lib/keywords/additionalProperties.js Outdated Show resolved Hide resolved
lib/keywords/definitions.js Outdated Show resolved Hide resolved
lib/keywords/dependentSchemas.js Outdated Show resolved Hide resolved
lib/keywords/id.js Outdated Show resolved Hide resolved
@jdesrosiers
Copy link
Collaborator

Please rebase

@mabagoury mabagoury changed the title add id keyword decription to meta schema add keyword descriptions to meta schemas Mar 31, 2024
@mabagoury
Copy link
Author

This is still a work in progress. We have a bug rendering the markdown in Neovim. A \ at the end of the line is rendered as is instead of being interpreted as a hard line break.

@DarhkVoyd
Copy link

@jdesrosiers We have made the required changes to the description to keep them relatively simpler and easier to maintain.

@jdesrosiers
Copy link
Collaborator

Looks good other than some linting errors. After you fix the linting errors, please rebase and squash your commits. Then it'll be ready to merge.

Co-Authored-By: mabagoury <wnajsksos@gmail.com>
@jdesrosiers jdesrosiers merged commit 6a2702e into hyperjump-io:lsp Apr 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants