Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed: Remove 'subject' property from alert config #374

Merged
merged 4 commits into from
Sep 6, 2021

Conversation

armedi
Copy link
Contributor

@armedi armedi commented Sep 6, 2021

Monika Pull Request (PR)

What feature/issue does this PR add

this PR resolves #349

Additional note

  1. While updating the alert guide docs to remove the subject, I also remove references to the old alert format in the guide. This is advised by Pak Ariya in team weekly checkpoint.

@nicnocquee nicnocquee merged commit 2ee9f35 into hyperjumptech:main Sep 6, 2021
@armedi armedi deleted the feat/349-alert-config-fields branch October 11, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 'subject' property from alert config, and make 'message' property optional.
4 participants