Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add time elapsed in transaction list (Home) #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tiendn
Copy link

@tiendn tiendn commented Apr 30, 2024

Issues: UX performance about transaction list in page /home

We should have a time elapsed in transaction list (Home Screen) for better UX.

Solutions:

  • Add a TimeElapsed.tsx component with setInterval each second for checking new value of readable time string
  • Replace current function string to TimeElapsed component only on Home screen
Screen.Recording.2024-04-30.at.23.33.18.mov

Copy link

vercel bot commented Apr 30, 2024

Someone is attempting to deploy a commit to the Abacus Works Team on Vercel.

A member of the Team first needs to authorize it.

@jmrossy
Copy link
Collaborator

jmrossy commented May 2, 2024

Thanks for this contribution but it was intentional to keep the time sent static. We believe it's too much noise when all the numbers change constantly. But we'll consider your change and get back to you.

@tiendn
Copy link
Author

tiendn commented May 2, 2024

Can you tell me why the time is kept static? I think the animation, when a new transaction is coming, blurs and replaces, making it difficult to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants