Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testrecipient back to infra and CoreDeployer #3274

Closed
yorhodes opened this issue Feb 15, 2024 · 0 comments · Fixed by #3279
Closed

Add testrecipient back to infra and CoreDeployer #3274

yorhodes opened this issue Feb 15, 2024 · 0 comments · Fixed by #3279
Assignees

Comments

@yorhodes
Copy link
Collaborator

yorhodes commented Feb 15, 2024

Problem

We removed the testrecipient module from infra deploy recently. The TestRecipient deployment is also an unnecessary extra step in the runbook.

Solution

We should add it back and also have the CoreDeployer use the TestRecipientDeployer internally for one fewer default entrypoints.

It is still useful to have separate entrypoints for the testrecipient deploy to enable contexts with different ISM configurations.

aroralanuk added a commit that referenced this issue Feb 19, 2024
### Description

- Added `TestRecipientDeployer` to the core deployer because most of the
times, the TestRecipient is required right after core deployment and
it's very lightweight. The TestRecipient deployment is also an
unnecessary extra step in the runbook.
- Put it back in infra/deploy which gives the deployer the option to
deploy it separately.

### Drive-by changes

None

### Related issues

- fixes #3274

### Backward compatibility

Yes

### Testing

Fork tests
ltyu pushed a commit to ltyu/hyperlane-monorepo that referenced this issue Mar 13, 2024
)

### Description

- Added `TestRecipientDeployer` to the core deployer because most of the
times, the TestRecipient is required right after core deployment and
it's very lightweight. The TestRecipient deployment is also an
unnecessary extra step in the runbook.
- Put it back in infra/deploy which gives the deployer the option to
deploy it separately.

### Drive-by changes

None

### Related issues

- fixes hyperlane-xyz#3274

### Backward compatibility

Yes

### Testing

Fork tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants