Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployed block numbers to indexable contracts #2672

Merged
merged 5 commits into from
Aug 18, 2023
Merged

Conversation

yorhodes
Copy link
Collaborator

@yorhodes yorhodes commented Aug 17, 2023

Description

Stores immutable deployment block number for use by agent indexers.

Drive-by changes

Removes unused pausable reentrancy guard

Related issues

Backward compatibility

Yes

Testing

Unit Tests

@yorhodes yorhodes changed the base branch from main to v3 August 17, 2023 22:33
Copy link
Contributor

@aroralanuk aroralanuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the block number test for mailbox too?

solidity/contracts/Mailbox.sol Outdated Show resolved Hide resolved
solidity/contracts/igps/InterchainGasPaymaster.sol Outdated Show resolved Hide resolved
@yorhodes yorhodes changed the title indexed block number Add deployed block numbers to indexable contracts Aug 18, 2023
@yorhodes yorhodes enabled auto-merge (squash) August 18, 2023 16:10
@yorhodes yorhodes merged commit a776131 into v3 Aug 18, 2023
4 of 5 checks passed
@yorhodes yorhodes deleted the indexed-block-number branch August 18, 2023 16:30
yorhodes added a commit that referenced this pull request Aug 18, 2023
@yorhodes yorhodes mentioned this pull request Aug 18, 2023
yorhodes added a commit that referenced this pull request Sep 13, 2023
@yorhodes yorhodes mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants