Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitor warp balances script #2682

Merged
merged 35 commits into from
Sep 6, 2023
Merged

Monitor warp balances script #2682

merged 35 commits into from
Sep 6, 2023

Conversation

aroralanuk
Copy link
Contributor

@aroralanuk aroralanuk commented Aug 22, 2023 •
edited
Loading

Description

  • Script to monitor token balances for Nautilus-Zebec-Solana warp route (hardcoded)
  • Helm command to deploy warp route monitoring script to Kubernetes

Drive-by changes

  • Updated default version to testnet3 for kathy and liquidity-layer

Related issues

Backward compatibility

Yes

Testing

Manual

@codecov
Copy link

codecov bot commented Aug 23, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (a9b522c) 64.50% compared to head (e11f162) 64.50%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2682   +/-   ##
=======================================
  Coverage   64.50%   64.50%           
=======================================
  Files          91       91           
  Lines        1386     1386           
  Branches      185      185           
=======================================
  Hits          894      894           
  Misses        485      485           
  Partials        7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aroralanuk aroralanuk changed the base branch from main to sealevelTokenAdapter August 24, 2023 23:17
jmrossy
jmrossy reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the helm charts, just looking at the TS code

typescript/infra/scripts/warp-routes/monitor-warp-routes-balances.ts Show resolved Hide resolved
typescript/infra/scripts/warp-routes/token_config.ts Outdated Show resolved Hide resolved
tkporter
tkporter reviewed Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we need to fix the crashing of the monitoring script pod

typescript/infra/scripts/warp-routes/monitor-warp-routes-balances.ts Outdated Show resolved Hide resolved
typescript/infra/scripts/warp-routes/monitor-warp-routes-balances.ts Outdated Show resolved Hide resolved
typescript/infra/scripts/warp-routes/monitor-warp-routes-balances.ts Outdated Show resolved Hide resolved
Base automatically changed from sealevelTokenAdapter to main September 4, 2023 19:50
jmrossy
jmrossy approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the Typescript parts with a few comments to address before merging please :)
Recommend an approval from someone for the helm charts too

typescript/token/src/consts/values.ts Outdated Show resolved Hide resolved
typescript/infra/src/config/nautilus_token_config.ts Outdated Show resolved Hide resolved
typescript/infra/src/config/nautilus_token_config.ts Outdated Show resolved Hide resolved
tkporter
tkporter approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@tkporter tkporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you!

typescript/infra/scripts/warp-routes/monitor-warp-routes-balances.ts Outdated Show resolved Hide resolved
typescript/infra/scripts/warp-routes/monitor-warp-routes-balances.ts Outdated Show resolved Hide resolved
@aroralanuk aroralanuk enabled auto-merge (squash) September 6, 2023 17:44
@aroralanuk aroralanuk merged commit 2b5d4c7 into main Sep 6, 2023
24 checks passed
@aroralanuk aroralanuk deleted the monitor-warp-balances branch September 6, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nambrot nambrot nambrot left review comments

@jmrossy jmrossy jmrossy approved these changes

@tkporter tkporter tkporter approved these changes

@asaj asaj Awaiting requested review from asaj

@mattiekat mattiekat Awaiting requested review from mattiekat

@yorhodes yorhodes Awaiting requested review from yorhodes

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aroralanuk @nambrot @jmrossy @tkporter