Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hook rotation in core deployer #2834

Merged
merged 20 commits into from
Oct 23, 2023
Merged

Support hook rotation in core deployer #2834

merged 20 commits into from
Oct 23, 2023

Conversation

yorhodes
Copy link
Collaborator

@yorhodes yorhodes commented Oct 23, 2023

Description

  • Update core deployer to rotate hooks
  • Add unit tests for core hook configuration

Drive-By Changes

  • Removes TestMultisigIsm in favor of TestIsm

Backward compatibility

Yes

Testing

Unit Tests

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #2834 (67607b7) into v3 (746026a) will increase coverage by 0.10%.
Report is 1 commits behind head on v3.
The diff coverage is n/a.

❗ Current head 67607b7 differs from pull request most recent head 53c2052. Consider uploading reports for the commit 53c2052 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2834      +/-   ##
==========================================
+ Coverage   61.86%   61.97%   +0.10%     
==========================================
  Files         100       99       -1     
  Lines        1007     1002       -5     
  Branches      104      104              
==========================================
- Hits          623      621       -2     
+ Misses        347      343       -4     
- Partials       37       38       +1     
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 67.93% <ø> (ø)
isms 67.91% <ø> (-0.75%) ⬇️
token 55.44% <ø> (ø)
middlewares 73.17% <ø> (ø)

Copy link
Contributor

@nambrot nambrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly nits

typescript/sdk/src/core/CoreDeployer.hardhat-test.ts Outdated Show resolved Hide resolved
typescript/sdk/src/core/CoreDeployer.hardhat-test.ts Outdated Show resolved Hide resolved
typescript/sdk/src/core/HyperlaneCoreDeployer.ts Outdated Show resolved Hide resolved
typescript/sdk/src/core/HyperlaneCoreDeployer.ts Outdated Show resolved Hide resolved
typescript/sdk/src/deploy/HyperlaneDeployer.ts Outdated Show resolved Hide resolved
typescript/sdk/src/deploy/HyperlaneDeployer.ts Outdated Show resolved Hide resolved
@yorhodes yorhodes merged commit 49fc06e into v3 Oct 23, 2023
4 checks passed
@yorhodes yorhodes deleted the v3-hook-changes branch October 23, 2023 23:11
@yorhodes yorhodes mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants