Graduate to yarn 4 🧶 #2899
Merged
Graduate to yarn 4 🧶 #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorhodes
requested review from
nambrot,
tkporter and
aroralanuk
as code owners
aroralanuk
approved these changes
Nov 8, 2023
jmrossy
reviewed
Nov 9, 2023
jmrossy
reviewed
Nov 9, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v3 #2899 +/- ##
=======================================
Coverage 68.04% 68.04%
=======================================
Files 99 99
Lines 1017 1017
Branches 106 106
=======================================
Hits 692 692
Misses 286 286
Partials 39 39
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| function _getConfiguredHook( | ||
| bytes calldata message | ||
| ) internal view virtual returns (IPostDispatchHook hook) { |
Check notice
Code scanning / Slither
Local variable shadowing
| DomainRoutingHook(mailbox, owner) | ||
| {} | ||
| constructor( | ||
| address mailbox, |
Check notice
Code scanning / Slither
Local variable shadowing
| returns (IInterchainSecurityModule) | ||
| { | ||
| function recipientIsm( | ||
| address _recipient |
Check notice
Code scanning / Slither
Missing zero address validation
jmrossy
approved these changes
Nov 9, 2023
Merged
yorhodes
pushed a commit
that referenced
this pull request
Jan 3, 2024
### Description In #2899 we upgraded to OZ 4.9.3 which changed the bytecode of proxy. This change adds another constant as a valid proxy bytecode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by changes
Related issues
Backward compatibility
Testing