Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage layout diff checks #2991

Merged
merged 31 commits into from
Nov 30, 2023
Merged

Add storage layout diff checks #2991

merged 31 commits into from
Nov 30, 2023

Conversation

yorhodes
Copy link
Collaborator

@yorhodes yorhodes commented Nov 28, 2023

Description

  • Add yarn workspace @hyperlane-xyz/core storage script
  • Add storage-analysis workflow for comparing diff on PRs between base and HEAD

Drive-By

  • Rename StaticProtocolFee to ProtocolFee to reflect actual behavior and include in storage layout checks

Related issues

Backward compatibility

Yes

Testing

CI

0xmichalis and others added 5 commits November 9, 2023 08:18
Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: 212ced2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/core Patch
@hyperlane-xyz/cli Patch
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hyperlane-xyz hyperlane-xyz deleted a comment from github-actions bot Nov 29, 2023
@yorhodes yorhodes changed the title Add storage layout snapshots Add storage layout diff checks Nov 29, 2023
@hyperlane-xyz hyperlane-xyz deleted a comment from github-actions bot Nov 30, 2023
solidity/test/hooks/StaticProtocolFee.t.sol Outdated Show resolved Hide resolved
@yorhodes yorhodes enabled auto-merge (squash) November 30, 2023 17:06
@yorhodes yorhodes merged commit 3501755 into main Nov 30, 2023
9 of 16 checks passed
@yorhodes yorhodes deleted the storage-snapshots branch November 30, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

CI should show storage layout changes in PRs
3 participants