Improve warp and kurtosis deploy command dx #2994
Merged
+100
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve chain selection for kurtosis agent deploy Fix chain metadata error and add unit test
jmrossy
requested review from
yorhodes,
aroralanuk,
Skunkchain and
avious00
as code owners
🦋 Changeset detectedLatest commit: 4aeb291 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jmrossy
commented
Nov 28, 2023
jmrossy
commented
Nov 28, 2023
nambrot
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add artifact selection step to warp deploy
Improve chain selection for kurtosis agent deploy
Drive-by changes
Fix chain metadata error and add unit test
Related issues
Fixes https://github.com/hyperlane-xyz/issues/issues/774
Backward compatibility
Small break in kurtosis deploy args, likely won't be noticed.
Testing
Manual