Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new ethers-rs version that should work with BSC #3000

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

tkporter
Copy link
Collaborator

@tkporter tkporter commented Nov 29, 2023

Description

Uses a version of our ethers fork with hyperlane-xyz/ethers-rs#10, which adds back a change that I had reverted from hyperlane-xyz/ethers-rs#8

This is required to fix bsc / bsctestnet txs, where the base fee is 0 and we want to estimate the priority fee

Drive-by changes

n/a

Related issues

n/a

Backward compatibility

ye

Testing

deployed and saw successful bsc / bsctestnet msgs

Copy link

changeset-bot bot commented Nov 29, 2023

⚠️ No Changeset found

Latest commit: 183c248

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tkporter tkporter changed the title [draft] Use new ethers-rs version that should work with BSC Use new ethers-rs version that should work with BSC Nov 29, 2023
@tkporter tkporter marked this pull request as ready for review November 29, 2023 15:51
@tkporter tkporter merged commit ffd4de4 into main Nov 29, 2023
10 of 16 checks passed
@tkporter tkporter deleted the trevor/new-ethers-nov-29-pt-2 branch November 29, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants