Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add figlet to CLI #3008

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Add figlet to CLI #3008

merged 3 commits into from
Dec 4, 2023

Conversation

yorhodes
Copy link
Collaborator

@yorhodes yorhodes commented Dec 1, 2023

Description

Adds fun figlet command to CLI :)

Drive-by changes

Related issues

Backward compatibility

Testing

Copy link

changeset-bot bot commented Dec 1, 2023

🦋 Changeset detected

Latest commit: 270342d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@hyperlane-xyz/cli Patch
@hyperlane-xyz/core Patch
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

typescript/cli/cli.ts Show resolved Hide resolved
Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the CLI handles keys, we should probably keep the dep tree minimal. That said, the figlet code looks legit and the solana + cosmos libs we require are almost certainly an insecure mess anyway... so 🤷

@yorhodes yorhodes enabled auto-merge (squash) December 4, 2023 23:36
@yorhodes yorhodes merged commit c606b6a into main Dec 4, 2023
8 of 14 checks passed
@yorhodes yorhodes deleted the cli-banner branch December 4, 2023 23:40
nambrot added a commit that referenced this pull request Dec 6, 2023
nambrot added a commit that referenced this pull request Dec 7, 2023
This reverts commit c606b6a.

### Description

<!--
What's included in this PR?
-->

### Drive-by changes

<!--
Are there any minor or drive-by changes also included?
-->

### Related issues

<!--
- Fixes #[issue number here]
-->

### Backward compatibility

<!--
Are these changes backward compatible? Are there any infrastructure
implications, e.g. changes that would prohibit deploying older commits
using this infra tooling?

Yes/No
-->

### Testing

<!--
What kind of testing have these changes undergone?

None/Manual/Unit Tests
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants