Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:don't prompt user for multisig config if chain is core #3021

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

aroralanuk
Copy link
Contributor

@aroralanuk aroralanuk commented Dec 5, 2023

Description

  • don't restrict user to having two chains for ism config
  • if the user accidentally picks two chains, we prompt them again to confirm if they don't want to use the hyperlane validators for their multisigconfig

Drive-by changes

None

Related issues

Backward compatibility

Yes

Testing

Manual between arbitrumgoerli and anvil1

Copy link

changeset-bot bot commented Dec 5, 2023

🦋 Changeset detected

Latest commit: 2906eeb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@hyperlane-xyz/cli Patch
@hyperlane-xyz/core Patch
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aroralanuk aroralanuk changed the title Don fix:don't prompt user for multisig config if chain is core Dec 5, 2023
typescript/cli/src/config/multisig.ts Outdated Show resolved Hide resolved
typescript/cli/src/config/multisig.ts Outdated Show resolved Hide resolved
typescript/cli/src/utils/chains.ts Outdated Show resolved Hide resolved
typescript/cli/src/utils/chains.ts Outdated Show resolved Hide resolved
.changeset/ninety-seas-chew.md Outdated Show resolved Hide resolved
@aroralanuk aroralanuk merged commit 2da6cce into main Dec 5, 2023
8 of 14 checks passed
@aroralanuk aroralanuk deleted the kunal/cli-dont-prompt-user-for-core-validators branch December 5, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants