Configs/env vars: s/OPT_/ABC_. #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had lots of environment variables prefixed with OPT as a holdover from the Optics fork. This PR tries to migrate them to Abacus-specific prefix of ABC, which is something we'd like to do prior to handing operational responsibility for running agents to any third parties, since there will be some inherent resistance in persuading a group like that to rename all configuration variables.
|
Thanks, I'll wait for Trevor. |
… variable in run-locally.sh
|
Resolved merge conflict (new whitelist-related env var for relayer in run-locally.sh), verified still works by running run-locally.sh and watching logs. |
…from agent helm command
… webbhorn/s-slash-opt-slash-abc
tkporter
approved these changes
Jun 15, 2022
|
Thanks! |
yorhodes
pushed a commit
that referenced
this pull request
Jun 29, 2022
* Transition to Abacus-themed env var prefix. Previously we had lots of environment variables prefixed with OPT as a holdover from the Optics fork. This PR tries to migrate them to Abacus-specific prefix of ABC, which is something we'd like to do prior to handing operational responsibility for running agents to any third parties, since there will be some inherent resistance in persuading a group like that to rename all configuration variables. * Update image to use ABC_ instead of OPT_, rm --debug --dry-run flags from agent helm command Co-authored-by: Trevor Porter <trkporter@ucdavis.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had lots of environment variables prefixed with OPT
as a holdover from the Optics fork. This PR tries to migrate them to
Abacus-specific prefix of ABC, which is something we'd said we'd like
to do prior to handing operational responsibility for running agents to
any third parties, since there will be some inherent resistance in
persuading a group like that to rename all configuration variables.
If desired, I'm happy to hold on this since we have so much in-flight
at the moment, just sending out for initial comment. On the other hand,
maybe it's better to catch and fix any issues as soon as we can.
This was a fairly blind find-and-replace for OPT_ and OPT strings within
the repo. I'm less familiar with the agent deploy/release process so am
leaning to some extent on @tkporter / @nambrot to comment on whether
I've managed to miss any of the critical config-generating pieces of code.