-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helloworld kathy #569
Merged
Merged
helloworld kathy #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Transfer ownership of Router in RouterDeployer * Improve router config/deploy/init (#557) * Add default initialize to Router * Remove proxies from router framework Co-authored-by: yorhodes <yorke@useabacus.network>
This was referenced Jun 9, 2022
asaj
reviewed
Jun 9, 2022
jmrossy
reviewed
Jun 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, just some small stuff
7 tasks
Hoist resolveJsonModule ts config to root
jmrossy
approved these changes
Jun 15, 2022
* Refactor Helloworld Kathy * Move ts-ignore * Throw error when addresses do not exist
yorhodes
added a commit
that referenced
this pull request
Jun 29, 2022
* Alpha7 * Checker * Move AbacusCoreChecker to deploy * Actually check inbox domain configuration (#544) * Transfer ownership of Router in RouterDeployer (#546) * Transfer ownership of Router in RouterDeployer * Improve router config/deploy/init (#557) * Add default initialize to Router * Remove proxies from router framework Co-authored-by: yorhodes <yorke@useabacus.network> * Update router tests for initialization * Move libs to contracts dir * Publish alpha12 * Publish beta1 * Small adjustments * Fix prettier in core * Fix lint * Add newlines to package json * Publish beta3 * Add hello world commands to infra * Make hello world artifacts consistent with infra * Add back helloworld after merge * Fix kathy scripts for 0.2.2 Hoist resolveJsonModule ts config to root * Run prettier * Cleanup tsconfig trailing commas * Refactor Helloworld Kathy (#616) * Refactor Helloworld Kathy * Move ts-ignore * Throw error when addresses do not exist Co-authored-by: nambrot <nambrot@googlemail.com> Co-authored-by: J M Rossy <jm.rossy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Turn HelloWorld into kathy scripts #536