Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor config in optics-deploy #67

Merged
merged 31 commits into from
Feb 7, 2022
Merged

Refactor config in optics-deploy #67

merged 31 commits into from
Feb 7, 2022

Conversation

asaj
Copy link
Contributor

@asaj asaj commented Feb 3, 2022 •
edited
Loading

This PR does the following:

  • Move contract deploy and verification output from rust/config to optics-deploy
  • Move chain specific config in optics-deploy from config/**/NETWORK.ts to config/networks/**/NETWORK.ts
  • Move environment specific config in optics-deploy from config/**/NETWORK.ts and scripts/ENV/agentConfig.ts to config/environments/ENV/
  • Move config type definitions to optics-deploy/src/config/
  • Modify agentConfig to reflect mutually exclusive gcp/aws parameters
  • Dedup CoreConfig to share contract initialization parameters across chains
  • Rename governance to governanceRouter
  • Reduce boiler plate code in optics-deploy/scripts
  • Rename ambiguous config variables to chain
  • Move TestBridgeDeploy to optics-test, remove getTestChain from optics-deploy in favor of the implementation in optics-tests
  • Remove unused freshFromConfig functions
  • Rename deployer to signer in ChainConfig

Fixes #103
Creates:

nambrot
nambrot reviewed Feb 3, 2022
View reviewed changes
typescript/optics-deploy/proposal.md Outdated Show resolved Hide resolved
typescript/optics-deploy/proposal.md Outdated Show resolved Hide resolved
typescript/optics-deploy/proposal.md Outdated Show resolved Hide resolved
typescript/optics-deploy/proposal.md Outdated Show resolved Hide resolved
typescript/optics-deploy/proposal.md Outdated Show resolved Hide resolved
typescript/optics-deploy/proposal.md Outdated Show resolved Hide resolved
typescript/optics-deploy/proposal.md Outdated Show resolved Hide resolved
typescript/optics-deploy/proposal.md Outdated Show resolved Hide resolved
typescript/optics-deploy/proposal.md Outdated Show resolved Hide resolved
@asaj asaj changed the title Asaj/config Config refactor [DRAFT] Feb 3, 2022
@asaj asaj changed the title Config refactor [DRAFT] Config and optics-deploy refactor Feb 6, 2022
@asaj asaj changed the title Config and optics-deploy refactor Refactor config in optics-deploy Feb 6, 2022
@asaj asaj marked this pull request as ready for review February 6, 2022 03:12
nambrot
nambrot reviewed Feb 6, 2022
View reviewed changes
Copy link
Contributor

@nambrot nambrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't believe you just churned this out 🙏

typescript/optics-deploy/config/environments/dev/contracts/alfajores_verification.json Outdated Show resolved Hide resolved
typescript/optics-deploy/config/environments/dev/core.ts Show resolved Hide resolved
typescript/optics-deploy/config/networks/testnets/rinkarby.ts Show resolved Hide resolved
typescript/optics-deploy/scripts/dev/check-deploy.ts Show resolved Hide resolved
typescript/optics-deploy/scripts/dev/core.ts Outdated Show resolved Hide resolved
typescript/optics-deploy/scripts/dev/update-agents.ts Outdated Show resolved Hide resolved
typescript/optics-deploy/scripts/mainnet/bridge.ts Outdated Show resolved Hide resolved
typescript/optics-deploy/scripts/mainnet/upgrade-replica.ts Show resolved Hide resolved
typescript/optics-deploy/src/config/addresses.ts Show resolved Hide resolved
@asaj asaj mentioned this pull request Feb 7, 2022
Closed
@asaj asaj merged commit 7408737 into main Feb 7, 2022
@asaj asaj deleted the asaj/config branch February 7, 2022 04:49
@tkporter tkporter mentioned this pull request Apr 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nambrot nambrot nambrot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make optics-deploy the logical home for config
2 participants
@asaj @nambrot