Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Remove phoreproject/bls dependency #2248

Closed
kdimak opened this issue Oct 19, 2020 · 5 comments · Fixed by #2294
Closed

Remove phoreproject/bls dependency #2248

kdimak opened this issue Oct 19, 2020 · 5 comments · Fixed by #2294
Assignees
@kdimak

Comments

@kdimak
Copy link
Contributor

kdimak commented Oct 19, 2020

We use Fr type from phoreproject/bls to implement BBS+, it's missing in kilic/bls12-381
@mikelodder7 said that we can use math.big mod Q (from G1.Q).
@kdimak kdimak self-assigned this Oct 19, 2020
This was referenced Oct 19, 2020
Merged
Closed
@kilic
Copy link

kilic commented Oct 30, 2020

Fr type is now implemented in kilic/bls12-381

@llorllale
Copy link
Contributor

Thank you @kilic !

@kdimak
Copy link
Contributor Author

kdimak commented Nov 3, 2020

Hi @kilic ! Thank you for implementing Fr type. I almost completed the migration from phoreproject/bls to kilic/bls12-381. One thing missing I see for now is Fr.Inverse(). Could you help us with this? I tried to implement this myself taking inverse(inv, e *fe) as a reference but did not succeed.

kdimak added a commit to kdimak/aries-framework-go that referenced this issue Nov 3, 2020
@kdimak
refactor: Use Fr type from kilic/bls12-381 for BBS+
bff2c97 
Signed-off-by: Dmitriy Kinoshenko <dkinoshenko@gmail.com>

hyperledger-archives#2248
@kdimak kdimak mentioned this issue Nov 3, 2020
Merged
@kilic
Copy link

kilic commented Nov 4, 2020 •
edited
Loading

https://github.com/kilic/bls12-381/blob/a288617c07f1bd60613c43dbde211b4a911e4791/fr.go#L257

@kdimak, we have it now.

kdimak added a commit to kdimak/aries-framework-go that referenced this issue Nov 4, 2020
@kdimak
refactor: Use Fr.Inverse() from kilic lib
22b1766 
closes hyperledger-archives#2248

Signed-off-by: Dmitriy Kinoshenko <dkinoshenko@gmail.com>
@kdimak kdimak mentioned this issue Nov 4, 2020
Merged
@kdimak
Copy link
Contributor Author

kdimak commented Nov 4, 2020

https://github.com/kilic/bls12-381/blob/a288617c07f1bd60613c43dbde211b4a911e4791/fr.go#L257

@kdimak, we have it now.

Superb! I've just checked it, works like a charm. Thank you indeed @kilic !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kdimak kdimak

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Use Fr.Inverse() from kilic lib kdimak/aries-framework-go
3 participants
@llorllale @kdimak @kilic