Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

SD-JWT: Additional verification when creating disclosed claims (Verifier) #3519

Closed
sandrask opened this issue Feb 7, 2023 · 0 comments · Fixed by #3522
Closed

SD-JWT: Additional verification when creating disclosed claims (Verifier) #3519

sandrask opened this issue Feb 7, 2023 · 0 comments · Fixed by #3522
Assignees
@sandrask
Labels
enhancement New feature or request
Milestone
0.1.7

Comments

@sandrask
Copy link
Contributor

sandrask commented Feb 7, 2023

Additional validation when processing disclosures to assemble disclosed claims:

  • If there is more than one place where the digest is included, the Verifier MUST reject the Presentation.
  • If the claim name already exists at the same level, the Verifier MUST reject the Presentation.
  • If the claim value contains an object with an _sd key (at the top level or nested deeper), the Verifier MUST reject the Presentation.
@sandrask sandrask self-assigned this Feb 7, 2023
@sandrask sandrask added this to the 0.1.7 milestone Feb 7, 2023
@sandrask sandrask added the enhancement New feature or request label Feb 7, 2023
sandrask added a commit to sandrask/aries-framework-go that referenced this issue Feb 9, 2023
@sandrask
chore: Additional validation for verifier
2fcf4a9 
Additional validation when processing disclosures to assemble disclosed claims:

- If there is more than one place where the digest is included, the Verifier MUST reject the Presentation.
- If the claim name already exists at the same level, the Verifier MUST reject the Presentation.
- If the claim value contains an object with an _sd key (at the top level or nested deeper), the Verifier MUST reject the Presentation.

Closes hyperledger-archives#3519

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@sandrask sandrask mentioned this issue Feb 9, 2023
Merged
fqutishat pushed a commit that referenced this issue Feb 10, 2023
@sandrask
chore: Additional validation for verifier (#3522)
c509c1e 
Additional validation when processing disclosures to assemble disclosed claims:

- If there is more than one place where the digest is included, the Verifier MUST reject the Presentation.
- If the claim name already exists at the same level, the Verifier MUST reject the Presentation.
- If the claim value contains an object with an _sd key (at the top level or nested deeper), the Verifier MUST reject the Presentation.

Closes #3519

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandrask sandrask

Labels
enhancement New feature or request
Milestone
0.1.7
Development

Successfully merging a pull request may close this issue.

chore: Additional validation when creating disclosed claims (verifier) sandrask/aries-framework-go
1 participant
@sandrask