This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: rest client worker for aries JS #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llorllale
approved these changes
Feb 22, 2020
|
|
||
| export function loadWorker(pending, notifications, paths) { | ||
| const wasmJS = paths.wasmJS | ||
| const wasm = paths.wasm |
There was a problem hiding this comment.
oops :) will remove it
| */ | ||
|
|
||
| export function loadWorker(pending, notifications, paths) { | ||
| const wasmJS = paths.wasmJS |
There was a problem hiding this comment.
will remove it
| entry: path.join(PATHS.srcDir, "aries.js"), | ||
| target: 'web', | ||
| // enable below option during dev mode to get exact stacktrace during error | ||
| devtool: 'inline-source-map', |
There was a problem hiding this comment.
will remove it.
sudeshrshetty
force-pushed
the
aries-js-worker
branch
from
3fcd98c
to
147442b
Compare
llorllale
reviewed
Feb 22, 2020
cmd/aries-js-worker/package.json
Outdated
| @@ -37,12 +39,15 @@ | |||
| "copy-webpack-plugin": "5.1.1", | |||
| "file-loader": "5.0.2", | |||
| "webpack": "4.41.5", | |||
| "webpack-cli": "3.3.10", | |||
| "webpack-cli": "^3.3.10", | |||
cmd/aries-js-worker/package.json
Outdated
| "webpack-merge": "4.2.2", | ||
| "webpack-shell-plugin": "0.5.0" | ||
| }, | ||
| "engines": { | ||
| "node": ">=12.14", | ||
| "npm": ">=6.13" | ||
| }, | ||
| "dependencies": { | ||
| "axios": "^0.19.2" |
troyronda
reviewed
Feb 22, 2020
| @@ -7,8 +7,9 @@ | |||
| "scripts": { | |||
| "build:node": "webpack --config ./webpack.config.node.js --mode=production", | |||
| "build:web": "webpack --config ./webpack.config.web.js --mode=production", | |||
There was a problem hiding this comment.
@llorllale @sudeshrshetty I wonder if web and node names should include that they are wasm. (followup).
troyronda
approved these changes
Feb 22, 2020
|
@sudeshrshetty we should add support for WebSocket notifications (#471) and then connect to the WS endpoint for rest notifications. REST JS Wrapper notification support: |
- Switching JS source from `../dist/web` to `../dist/rest` will make aries js worker to run in rest agent client mode. - Web worker will be using agent rest client endpoints instead of aries wasm command handlers. - Except worker javascript, all the other functionalities and interfaces will remain same. - added switch (to REST/WASM worker) feature in presentation html for demonstration/testing. //TODO :Currently incoming topics/messages should be looked up in webhook URL of corresponding REST agent, javascript notifier listening to webhook URL will be added in future. Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
sudeshrshetty
force-pushed
the
aries-js-worker
branch
from
147442b
to
6bbc5a9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
../dist/webto../dist/restwill makearies js worker to run in rest agent client mode.
aries wasm command handlers.
will remain same.
demonstration/testing.
//TODO :Currently incoming topics/messages should be looked up in
webhook URL of corresponding REST agent, javascript notifier listening
to webhook URL will be added in future.
Signed-off-by: sudesh.shetty sudesh.shetty@securekey.com