This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: Add accept header in resolver http binding #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fqutishat
requested review from
sandrask,
rolsonquadras,
troyronda and
llorllale
sandrask
reviewed
Feb 27, 2020
rolsonquadras
approved these changes
Feb 27, 2020
sandrask
reviewed
Feb 27, 2020
sandrask
approved these changes
Feb 27, 2020
closes #1384 Signed-off-by: Firas Qutishat <firas.qutishat@securekey.com>
soluchok
approved these changes
Feb 27, 2020
Comment on lines
+20
to
+22
| const ( | ||
| didLDJson = "application/did+ld+json" | ||
| ) |
There was a problem hiding this comment.
nit: should be done in one line
| if err != nil { | ||
| return nil, fmt.Errorf("HTTP Get request failed: %w", err) | ||
| } | ||
|
|
||
| defer closeResponseBody(resp.Body) | ||
|
|
||
| if resp.StatusCode == http.StatusOK { | ||
| var gotBody []byte | ||
| var gotBody []byte |
There was a problem hiding this comment.
Redundant definition. Lint should not complain about gotBody, err :=
troyronda
approved these changes
Feb 27, 2020
llorllale
approved these changes
Feb 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1384
Signed-off-by: Firas Qutishat firas.qutishat@securekey.com