This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: webnotfiers to send topic information #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudeshrshetty
force-pushed
the
WS-REST
branch
6 times, most recently
from
716691c
to
99eba0d
Compare
fqutishat
approved these changes
Feb 28, 2020
test/bdd/webhook/main.go
Outdated
| func main() { | ||
| port := os.Getenv("WEBHOOK_PORT") | ||
| if port == "" { | ||
| panic("port to be passed as ENV variable") | ||
| } | ||
|
|
||
| router := mux.NewRouter().StrictSlash(true) | ||
| router.HandleFunc(connectionsPath, connections).Methods(http.MethodPost) | ||
| router.HandleFunc("/", connections).Methods(http.MethodPost) |
There was a problem hiding this comment.
May be we can change the name of handler from connections to handleNotification or something like that. With this refactor, the api will handle generic notification and not just related to connections/didexchange functionality.
sudeshrshetty
force-pushed
the
WS-REST
branch
from
99eba0d
to
7743ce5
Compare
- in previous version, web notifier topics are only used for resolving/building URLs which was forcing subscribers to support path matching topic names (challenge: topic name is private and dynamic based on usecases) - changes: web notifiers will send message containing uniquer ID, Topic Name and Raw JSON message to given webnotfier endpoint. - This fixed issue in JS worker where it wasn't able to find topic of incoming messages. - closes hyperledger-archives#1323 Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
sudeshrshetty
force-pushed
the
WS-REST
branch
from
7743ce5
to
3757a16
Compare
rolsonquadras
approved these changes
Feb 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLs which was forcing subscribers to support path matching topic names
(challenge: topic name are private and dynamic based on usecases)
Name and Raw JSON message to given webnotfier endpoint.
incoming messages.
Signed-off-by: sudesh.shetty sudesh.shetty@securekey.com