This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: Removes storage implementations (Couchdb, MySQL) #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2245 +/- ##
==========================================
+ Coverage 89.57% 89.81% +0.24%
==========================================
Files 221 219 -2
Lines 15094 14799 -295
==========================================
- Hits 13520 13292 -228
+ Misses 935 896 -39
+ Partials 639 611 -28
Continue to review full report at Codecov.
|
troyronda
reviewed
Oct 19, 2020
troyronda
reviewed
Oct 19, 2020
troyronda
reviewed
Oct 19, 2020
troyronda
reviewed
Oct 19, 2020
troyronda
reviewed
Oct 19, 2020
troyronda
reviewed
Oct 19, 2020
| @@ -37,20 +36,20 @@ type StorePrefixWrapper struct { | |||
|
|
|||
| // Put stores v with k ID by prefixing it with IDPrefix. | |||
| func (b *StorePrefixWrapper) Put(k string, v []byte) error { | |||
| if k == "" { | |||
| return fmt.Errorf("cannot Put with empty key") | |||
| if k != "" { | |||
There was a problem hiding this comment.
We should not check it here. We need to rely on DB.
fqutishat
approved these changes
Oct 19, 2020
|
Note: These are available as part of aries-framework-go-ext - https://github.com/hyperledger/aries-framework-go-ext/tree/main/component/storage |
rolsonquadras
approved these changes
Oct 19, 2020
baha-ai
approved these changes
Oct 19, 2020
Signed-off-by: Andrii Soluk <isoluchok@gmail.com>
This was referenced Oct 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes Couchdb and MySQL and implementations.
Signed-off-by: Andrii Soluk isoluchok@gmail.com