This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
refactor: VDR support for deactivate/update #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2473 +/- ##
==========================================
+ Coverage 89.22% 89.24% +0.01%
==========================================
Files 253 253
Lines 18495 18517 +22
==========================================
+ Hits 16503 16525 +22
Misses 1173 1173
Partials 819 819
Continue to review full report at Codecov.
|
fqutishat
force-pushed
the
2423
branch
2 times, most recently
from
a1bb153
to
9c99646
Compare
troyronda
approved these changes
Jan 21, 2021
| func (v *VDR) Deactivate(did string, opts ...vdrapi.DIDMethodOption) error { | ||
| return fmt.Errorf("not supported") | ||
| } | ||
|
|
||
| // Accept did method. |
There was a problem hiding this comment.
How does VDR indicate that it can handle only resolution vs the full interface?
There was a problem hiding this comment.
I think we need to consider having two sets of VDRs loaded into the framework:
- resolvers
- writers / full lifecycle
and make the writer interface a superset of the resolver interface.
fqutishat
force-pushed
the
2423
branch
2 times, most recently
from
c107224
to
d0b6dc3
Compare
closes hyperledger-archives#2423 Signed-off-by: Firas Qutishat <firas.qutishat@securekey.com>
sandrask
approved these changes
Jan 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2423
Signed-off-by: Firas Qutishat firas.qutishat@securekey.com