This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: new common wallet package #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudeshrshetty
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2670 +/- ##
==========================================
+ Coverage 88.36% 88.39% +0.03%
==========================================
Files 265 266 +1
Lines 21130 21172 +42
==========================================
+ Hits 18671 18715 +44
+ Misses 1433 1431 -2
Partials 1026 1026
Continue to review full report at Codecov.
|
troyronda
approved these changes
Mar 24, 2021
rolsonquadras
approved these changes
Mar 24, 2021
- all common internal source inside `pkg/client/vcwallet` moved to `pkg/wallet`. This new package will be reused by upcoming command controllers. - `vcwallet.New()` to unlock wallet during instantiation, where existing instances of same wallet will be locked. - some refactoring for SDK binding for better client experience. - Part of hyperledger-archives#2433 Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
sudeshrshetty
force-pushed
the
0.1.7-vcwallet
branch
from
a74e0ce
to
1c9f654
Compare
llorllale
pushed a commit
to llorllale/agent-sdk
that referenced
this pull request
Mar 25, 2021
Changes: * refactored VDR.Create(): hyperledger-archives/aries-framework-go#2665 * support for non-deterministic keys in storage FormattedProvider: hyperledger-archives/aries-framework-go#2667 * fixed didexchange.Client.CreateConnect(): hyperledger-archives/aries-framework-go#2670 Signed-off-by: George Aristy <george.aristy@securekey.com>
sudeshrshetty
pushed a commit
to sudeshrshetty/agent-sdk
that referenced
this pull request
Aug 31, 2021
Changes: * refactored VDR.Create(): hyperledger-archives/aries-framework-go#2665 * support for non-deterministic keys in storage FormattedProvider: hyperledger-archives/aries-framework-go#2667 * fixed didexchange.Client.CreateConnect(): hyperledger-archives/aries-framework-go#2670 Signed-off-by: George Aristy <george.aristy@securekey.com>
sudeshrshetty
added a commit
to sudeshrshetty/aries-framework-go
that referenced
this pull request
Oct 18, 2021
- all common internal source inside `pkg/client/vcwallet` moved to `pkg/wallet`. This new package will be reused by upcoming command controllers. - `vcwallet.New()` to unlock wallet during instantiation, where existing instances of same wallet will be locked. - some refactoring for SDK binding for better client experience. - Part of hyperledger-archives#2433 Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
sudeshrshetty
added a commit
to sudeshrshetty/aries-framework-go
that referenced
this pull request
Jan 22, 2022
- all common internal source inside `pkg/client/vcwallet` moved to `pkg/wallet`. This new package will be reused by upcoming command controllers. - `vcwallet.New()` to unlock wallet during instantiation, where existing instances of same wallet will be locked. - some refactoring for SDK binding for better client experience. - Part of hyperledger-archives#2433 Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/client/vcwalletmoved topkg/wallet. This new package will be reused by upcoming commandcontrollers.
vcwallet.New()to unlock wallet during instantiation, where existinginstances of same wallet will be locked.
Signed-off-by: sudesh.shetty sudesh.shetty@securekey.com