Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: vc wallet - derive credential #2695

Merged
merged 1 commit into from
Mar 29, 2021
Merged

feat: vc wallet - derive credential #2695

merged 1 commit into from
Mar 29, 2021

Conversation

sudeshrshetty
Copy link
Contributor

@codecov
Copy link

codecov bot commented Mar 29, 2021 •
edited

Codecov Report

Merging #2695 (f1e7157) into main (05bf9d0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head f1e7157 differs from pull request most recent head e712d4d. Consider uploading reports for the commit e712d4d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2695      +/-   ##
==========================================
+ Coverage   88.29%   88.31%   +0.01%     
==========================================
  Files         268      268              
  Lines       21461    21492      +31     
==========================================
+ Hits        18950    18981      +31     
  Misses       1464     1464              
  Partials     1047     1047
Impacted Files Coverage Δ
pkg/client/vcwallet/client.go 100.00% <100.00%> (ø)
pkg/wallet/options.go 100.00% <100.00%> (ø)
pkg/wallet/wallet.go 96.31% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05bf9d0...e712d4d. Read the comment docs.

troyronda
troyronda reviewed Mar 29, 2021
View reviewed changes
pkg/wallet/wallet.go
verifiable.NewVDRKeyResolver(c.ctx.VDRegistry()).PublicKeyFetcher(),
)

derived, err := vc.GenerateBBSSelectiveDisclosure(options.Frame, []byte(options.Nonce), pkFetcher)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: we should followup with a refactor of GenerateBBSSelectiveDisclosure into a NewCredential function and WithSelectiveDisclosure(vc, frame, nonce, ...) option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will create a task for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created: #2697

@sudeshrshetty
feat: vc wallet - derive credential
e712d4d 
- Closes hyperledger-archives#2694

Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
@troyronda troyronda merged commit b203155 into hyperledger-archives:main Mar 29, 2021
@sudeshrshetty sudeshrshetty mentioned this pull request Mar 29, 2021
Open
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this pull request Oct 18, 2021
@sudeshrshetty
feat: vc wallet - derive credential (hyperledger-archives#2695)
4a50833 
- Closes hyperledger-archives#2694

Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
sudeshrshetty added a commit to sudeshrshetty/aries-framework-go that referenced this pull request Jan 22, 2022
@sudeshrshetty
feat: vc wallet - derive credential (hyperledger-archives#2695)
6be33cb 
- Closes hyperledger-archives#2694

Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@troyronda troyronda troyronda approved these changes

@rolsonquadras rolsonquadras rolsonquadras approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VC wallet: derive credential feature
3 participants
@sudeshrshetty @troyronda @rolsonquadras