This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: apis to create keys in wallet kms #2769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2769 +/- ##
=======================================
Coverage 88.49% 88.50%
=======================================
Files 277 277
Lines 22840 22861 +21
=======================================
+ Hits 20213 20232 +19
- Misses 1545 1546 +1
- Partials 1082 1083 +1
Continue to review full report at Codecov.
|
rolsonquadras
approved these changes
Apr 29, 2021
sudeshrshetty
force-pushed
the
WALLET-CMD-CTRL
branch
5 times, most recently
from
80c1eaf
to
f971fcc
Compare
-EDV encryption & MAC key IDs cannot be passed as profile settings for localkms users since wallet creates local kms internally based on user's secret lock service. So wallet has to expose an API to generate EDV keys in wallet kms. - Closes hyperledger-archives#2768 Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
sudeshrshetty
force-pushed
the
WALLET-CMD-CTRL
branch
from
f971fcc
to
b92e6fa
Compare
fqutishat
approved these changes
Apr 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-EDV encryption & MAC key IDs cannot be passed as profile settings for
localkms users since wallet creates local kms internally based on user's
secret lock service. So wallet has to expose an API to generate EDV keys
in wallet kms.
Signed-off-by: sudesh.shetty sudesh.shetty@securekey.com