This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: correlating invitation with propose credential message #3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- WACI way of using invitation as parent threadID may not work with DIDCommV1 where parent thread ID gets reset by messenger while sending propose credential message - As a work around, invitation ID can be explicitly used while sending propose credential message - Part of hyperledger-archives#3073 Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
fqutishat
approved these changes
Jan 6, 2022
rolsonquadras
approved these changes
Jan 6, 2022
Codecov Report
@@ Coverage Diff @@
## main #3119 +/- ##
=======================================
Coverage 88.78% 88.78%
=======================================
Files 307 307
Lines 40742 40747 +5
=======================================
+ Hits 36173 36178 +5
Misses 3340 3340
Partials 1229 1229
Continue to review full report at Codecov.
|
sudeshrshetty
added a commit
to sudeshrshetty/aries-framework-go
that referenced
this pull request
Jan 22, 2022
…dger-archives#3119) - WACI way of using invitation as parent threadID may not work with DIDCommV1 where parent thread ID gets reset by messenger while sending propose credential message - As a work around, invitation ID can be explicitly used while sending propose credential message - Part of hyperledger-archives#3073 Signed-off-by: sudesh.shetty <sudesh.shetty@securekey.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DIDCommV1 where parent thread ID gets reset by messenger while sending
propose credential message
propose credential message
Signed-off-by: sudesh.shetty sudesh.shetty@securekey.com