Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: Legacy Anoncrypt(RFC-0019) DIDComm v1 implementation #3268

Merged
merged 5 commits into from
Jul 13, 2022

Conversation

Abdulbois
Copy link
Contributor

@Abdulbois Abdulbois commented Jul 8, 2022

Title:
Legacy Anoncrypt(RFC-0019) DIDComm v1 implementation

Description:
This is the PR to support legacy anoncrypt (pack/unpack) while DIDComm V1 is used.

Summary:
Add anoncrypt packing/unpacking using Chacha20 encryption algorithm

Signed-off-by: Abdulbois <abdulbois123@gmail.com>
Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com>
Copy link
Contributor

@baha-ai baha-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #3268 (443493e) into main (15a4bb4) will increase coverage by 0.00%.
The diff coverage is 89.18%.

@@           Coverage Diff            @@
##             main    #3268    +/-   ##
========================================
  Coverage   88.27%   88.28%            
========================================
  Files         312      315     +3     
  Lines       42436    42658   +222     
========================================
+ Hits        37461    37659   +198     
- Misses       3658     3674    +16     
- Partials     1317     1325     +8     
Impacted Files Coverage Δ
pkg/didcomm/packer/legacy/anoncrypt/pack.go 87.50% <87.50%> (ø)
pkg/didcomm/packer/legacy/anoncrypt/unpack.go 88.99% <88.99%> (ø)
pkg/didcomm/packer/legacy/anoncrypt/anoncrypt.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a4bb4...443493e. Read the comment docs.

Abdulbois and others added 3 commits July 12, 2022 11:53
Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com>
Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com>
@fqutishat fqutishat merged commit 12e93a0 into hyperledger-archives:main Jul 13, 2022
Abdulbois added a commit to Abdulbois/aries-framework-go that referenced this pull request Jul 13, 2022
…er-archives#3268)

* feat: Legacy Anoncrypt(RFC-0019) DIDComm v1 implementation

Signed-off-by: Abdulbois <abdulbois123@gmail.com>

* refactor: change copyright title

Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com>

* fix: golang-ci lint errors

Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com>

* fix: golang-ci lint errors

Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants