-
Notifications
You must be signed in to change notification settings - Fork 158
feat: add ext db packages to REST Agent (#3269) #3270
feat: add ext db packages to REST Agent (#3269) #3270
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3270 +/- ##
==========================================
+ Coverage 88.20% 88.25% +0.04%
==========================================
Files 316 312 -4
Lines 42925 42448 -477
==========================================
- Hits 37864 37461 -403
+ Misses 3715 3670 -45
+ Partials 1346 1317 -29
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution @afrancoc2000 .
Please fix the BDD test issues caused by go mod updates.
0a111c4
to
d821986
Compare
Thanks for the PR @afrancoc2000! (and extra thanks for updating the docs too!) Looks good to me. |
Thank you @sudeshrshetty and @DRK3 , I'm glad to help. Can you approve to run the workflows please? I made a change in the go.sum file and I would like to check if that fixes the problem with the BDD test. |
Hi guys, I fixed the nolint comments, can you please approve the workflows again, to check if its fixed? Thanks! |
e6cd52e
to
e8f8c87
Compare
Hi @sudeshrshetty @DRK3 @troyronda I did a rebase and squached the no-lint commit. Can you run the workflows again please? Thanks! |
@afrancoc2000 done, but still I can see some failures, Please check. |
1ba6cbf
to
e7fefb5
Compare
Hi @sudeshrshetty I fixed it, can we try again? thanks |
013dde0
to
e7fefb5
Compare
Hi @sudeshrshetty, @DRK3 I added the actions to my repo and I've been running them there unsuccessfully. I don't understand why, it's like the BDD simply stop running and the process completed with exit code 2. I think is a timeout thing because it always fails in a different place, I would like to run them here again to check, any idea what could it be? Also, I did a couple of tests changing stuff in my repo, without noticing I created a lot of actions in this repo, I apologize for that. Can you please cancel the extra actions? sorry about that. Thanks |
e7fefb5
to
a75aaa1
Compare
Hi @afrancoc2000, are you able to run the checks locally with |
Hi @DRK3, I have a windows machine and running |
Hi @afrancoc2000, yeah I believe the scripts only work on Linux and Mac. I tried running through |
(on a side note, if the scripts are only compatible with Linux and Mac, I could update the docs. @sudeshrshetty @rolsonquadras, do you know if they're supposed to work on Windows?) |
Signed-off-by: Ana Maria Franco <afrancoc2000@gmail.com>
a75aaa1
to
bc698fb
Compare
Hi @DRK3, Thank you, I ran the actions on my github again and the bdd tests are good |
Signed-off-by: Ana Maria Franco afrancoc2000@gmail.com
Title:
Adding extended database packages to the Rest Agent
Description:
The Rest Agent doesn't have an easy way to use the extended package databases, so, I'm adding the posibility to use them in here.
Issue 3269
Summary:
I'm adding support for the Rest Agent to: couchdb, mongodb, mysql, postgresql, from the aries-framework-go-ext package, and updating the docs.
Also I ran
go mod tidy -go=1.16 && go mod tidy -go=1.17
and updated the go.mod keeping compatibility with go 1.16. Not sure if compatibility with go 1.16 is still wanted.