Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: add ext db packages to REST Agent (#3269) #3270

Conversation

afrancoc2000
Copy link
Contributor

Signed-off-by: Ana Maria Franco afrancoc2000@gmail.com

Title:
Adding extended database packages to the Rest Agent

Description:
The Rest Agent doesn't have an easy way to use the extended package databases, so, I'm adding the posibility to use them in here.

Issue 3269

Summary:

I'm adding support for the Rest Agent to: couchdb, mongodb, mysql, postgresql, from the aries-framework-go-ext package, and updating the docs.

Also I ran go mod tidy -go=1.16 && go mod tidy -go=1.17 and updated the go.mod keeping compatibility with go 1.16. Not sure if compatibility with go 1.16 is still wanted.

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #3270 (d6054ee) into main (c28f931) will increase coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head d6054ee differs from pull request most recent head bc698fb. Consider uploading reports for the commit bc698fb to get more accurate results

@@            Coverage Diff             @@
##             main    #3270      +/-   ##
==========================================
+ Coverage   88.20%   88.25%   +0.04%     
==========================================
  Files         316      312       -4     
  Lines       42925    42448     -477     
==========================================
- Hits        37864    37461     -403     
+ Misses       3715     3670      -45     
+ Partials     1346     1317      -29     
Impacted Files Coverage Δ
cmd/aries-agent-rest/startcmd/start.go 77.51% <0.00%> (-1.74%) ⬇️
pkg/doc/did/helpers.go 78.57% <0.00%> (-14.23%) ⬇️
pkg/framework/aries/default.go 77.04% <0.00%> (-0.35%) ⬇️
pkg/controller/command/vcwallet/command.go 92.67% <0.00%> (-0.31%) ⬇️
pkg/didcomm/packager/packager.go 89.66% <0.00%> (-0.22%) ⬇️
pkg/didcomm/packer/legacy/anoncrypt/pack.go
pkg/didcomm/packer/legacy/anoncrypt/unpack.go
pkg/doc/jwt/jwt_support.go
pkg/didcomm/packer/legacy/anoncrypt/anoncrypt.go
pkg/didcomm/dispatcher/outbound/outbound.go 90.96% <0.00%> (+0.08%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Contributor

@sudeshrshetty sudeshrshetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution @afrancoc2000 .

Please fix the BDD test issues caused by go mod updates.

@afrancoc2000 afrancoc2000 force-pushed the feature/implement_extended_db_in_rest_agent branch from 0a111c4 to d821986 Compare July 12, 2022 01:15
@DRK3
Copy link
Contributor

DRK3 commented Jul 12, 2022

Thanks for the PR @afrancoc2000! (and extra thanks for updating the docs too!) Looks good to me.

@afrancoc2000
Copy link
Contributor Author

Thank you @sudeshrshetty and @DRK3 , I'm glad to help. Can you approve to run the workflows please? I made a change in the go.sum file and I would like to check if that fixes the problem with the BDD test.

@afrancoc2000
Copy link
Contributor Author

Hi guys, I fixed the nolint comments, can you please approve the workflows again, to check if its fixed? Thanks!

@afrancoc2000 afrancoc2000 force-pushed the feature/implement_extended_db_in_rest_agent branch from e6cd52e to e8f8c87 Compare July 18, 2022 18:31
@afrancoc2000
Copy link
Contributor Author

Hi @sudeshrshetty @DRK3 @troyronda I did a rebase and squached the no-lint commit. Can you run the workflows again please? Thanks!

@sudeshrshetty
Copy link
Contributor

@afrancoc2000 done, but still I can see some failures, Please check.

@afrancoc2000 afrancoc2000 force-pushed the feature/implement_extended_db_in_rest_agent branch 2 times, most recently from 1ba6cbf to e7fefb5 Compare July 20, 2022 01:48
@afrancoc2000
Copy link
Contributor Author

Hi @sudeshrshetty I fixed it, can we try again? thanks

@afrancoc2000 afrancoc2000 force-pushed the feature/implement_extended_db_in_rest_agent branch 2 times, most recently from 013dde0 to e7fefb5 Compare July 22, 2022 04:47
@afrancoc2000
Copy link
Contributor Author

Hi @sudeshrshetty, @DRK3 I added the actions to my repo and I've been running them there unsuccessfully. I don't understand why, it's like the BDD simply stop running and the process completed with exit code 2. I think is a timeout thing because it always fails in a different place, I would like to run them here again to check, any idea what could it be?

Also, I did a couple of tests changing stuff in my repo, without noticing I created a lot of actions in this repo, I apologize for that. Can you please cancel the extra actions? sorry about that.

Thanks

@afrancoc2000 afrancoc2000 force-pushed the feature/implement_extended_db_in_rest_agent branch from e7fefb5 to a75aaa1 Compare July 23, 2022 22:28
@DRK3
Copy link
Contributor

DRK3 commented Jul 25, 2022

Hi @afrancoc2000, are you able to run the checks locally with make all?

@afrancoc2000
Copy link
Contributor Author

afrancoc2000 commented Jul 26, 2022

Hi @DRK3, I have a windows machine and running make all gives me a lot of issues, running in windows I get path problems and in the wsl I get line endings errors, so I prefer running the actions on github, it's more straightforward. I'm going to try with a devcontainer though maybe that way make will work whithout issues

@DRK3
Copy link
Contributor

DRK3 commented Jul 26, 2022

Hi @afrancoc2000, yeah I believe the scripts only work on Linux and Mac. I tried running through make all on my Mac using your branch and it worked fine for me, so perhaps the CI was just really slow when you tested. @sudeshrshetty, can you get them to run again?

@DRK3
Copy link
Contributor

DRK3 commented Jul 26, 2022

(on a side note, if the scripts are only compatible with Linux and Mac, I could update the docs. @sudeshrshetty @rolsonquadras, do you know if they're supposed to work on Windows?)

Signed-off-by: Ana Maria Franco <afrancoc2000@gmail.com>
@afrancoc2000 afrancoc2000 force-pushed the feature/implement_extended_db_in_rest_agent branch from a75aaa1 to bc698fb Compare July 27, 2022 00:51
@afrancoc2000
Copy link
Contributor Author

Hi @DRK3, Thank you, I ran the actions on my github again and the bdd tests are good

@sudeshrshetty sudeshrshetty merged commit 2097e31 into hyperledger-archives:main Jul 27, 2022
@afrancoc2000 afrancoc2000 deleted the feature/implement_extended_db_in_rest_agent branch July 27, 2022 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants