This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
refactor: enable usage of legacy Anoncrypt packer. Make nested forwards while creating forward message. Add legacyForward model #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudeshrshetty
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
thanks for your contribution @Abdulbois.
PR looks good to me, but please also signoff your commits as per guidelines.
|
@Abdulbois can you please squash your commits. |
fqutishat
force-pushed
the
nested-forwards
branch
from
9c8df85
to
9ef0d4e
Compare
Codecov Report
@@ Coverage Diff @@
## main #3272 +/- ##
==========================================
+ Coverage 88.28% 88.29% +0.01%
==========================================
Files 315 315
Lines 42668 42706 +38
==========================================
+ Hits 37669 37709 +40
+ Misses 3674 3671 -3
- Partials 1325 1326 +1
Continue to review full report at Codecov.
|
Abdulbois
force-pushed
the
nested-forwards
branch
3 times, most recently
from
fc873de
to
e5f2607
Compare
|
@Abdulbois can you rebase |
Abdulbois
force-pushed
the
nested-forwards
branch
from
df4a167
to
2e9621f
Compare
…dger-archives#3259) this change updates the remote CryptoBox api URIs to point to remote KMS's key /wrap and /unwrap to match ECDH-ES and ECDH-1PU key wrapping. This change requires the KMS server to udpate /easy to /wrap, /easyOpen and /sealOpen to /unwrap Signed-off-by: Baha Shaaban <baha.shaaban@securekey.com> Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com>
…archives#3263) This change updates the webkms server in bdd tests and re enables commented out webkms tests requiring cryptobox's /wrap and /unwrap operations. closes hyperledger-archives#3262 Signed-off-by: Baha Shaaban <baha.shaaban@securekey.com> Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com>
…ds while creating forward message. Add legacyForward model - Add legacy Anoncrypt packer while creating packers - Add ability to create nested packed forwards (one nested forward for each routing key) - Check and convert msg field of Forward to Envelope in order to support DIDComm V1 Forward types - Revert part of 04bfea8 commit related to generating keys inside mediator service. Because with previous changes (having two types of generated keys belonging to the same router) it breaks Route Coordination protocol (while creating nested forwards it will pack two times to the same mediator then mediator cannot handle second forward message) Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com>
Abdulbois
force-pushed
the
nested-forwards
branch
from
2e9621f
to
d51cba2
Compare
…rwardMessage. Fix lint errors Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com>
Abdulbois
changed the title
Abdulbois
changed the title
done. Pls check it |
troyronda
approved these changes
Jul 17, 2022
fqutishat
approved these changes
Jul 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Enable legacy Anoncrypt packer. Make nested packed forwards while creating forward message
Summary: