feat: CL Anoncreds Crypto API #3275
Conversation
kgoncharov
force-pushed
the
cl-crypto-api-tink
branch
from
7535ddb
to
80abd8f
Compare
Codecov Report
@@ Coverage Diff @@
## main #3275 +/- ##
==========================================
+ Coverage 88.00% 88.02% +0.01%
==========================================
Files 322 323 +1
Lines 44389 44393 +4
==========================================
+ Hits 39066 39077 +11
+ Misses 3927 3920 -7
Partials 1396 1396
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -0,0 +1,316 @@ | |||
| //go:build ursa | |||
| // +build ursa | |||
There was a problem hiding this comment.
it looks like ursa tagged files are not included in our linter
There was a problem hiding this comment.
seems it'll take ursa and cgo to be provided in golangci-lint Docker container.
should we create a new image for lint with these dependencies inside and use it in check_lint.sh?
There was a problem hiding this comment.
Yeah, it seems the default golangci-lint won't have these tools, might as well create a new dedicated image. Thanks.
There was a problem hiding this comment.
@Baha-sk Where should I keep related Dockerfile and push the corresponding image?
Also, we could try to make a separate github job as Alex did for ursa tests - it'll use docker with pre-installed ursa
There was a problem hiding this comment.
you can create a ursa subfolder under images and have a new dockerfile there.
as for the job, i would recommend simply updating scripts/check_lint.sh with new entries for ursa linting using your new image.
There was a problem hiding this comment.
@Baha-sk can we postpone this chage to the next PR?
Currently, I'm not a contributor to af-go, since I haven't made any commit to the repo. Therefore, pipelines would be not started automatically. And it'll be painful to ask you to start pipeline on each of me changes during debug.
Although, I ran golangci-lint locally with ursa tag and made the fixes according to all lint warnings.
There was a problem hiding this comment.
no issues @kgoncharov, this is not mandatory, but a suggestion if you need to have a separate dockerfile for ursa builds.
kgoncharov
force-pushed
the
cl-crypto-api-tink
branch
from
a24ef7e
to
d65b676
Compare
pkg/crypto/tinkcrypto/primitive/cl/blinder/cl_blinder_key_manager.go
Outdated
Show resolved
Hide resolved
| //go:build ursa | ||
| // +build ursa |
There was a problem hiding this comment.
since the crypto api was updated to add the new CL functions, the framework won't compile without this build tag.
There was a problem hiding this comment.
as discussed in today's planning, since there are empty stubs in the non-ursa build, the framework should be ok. Further changes will be needed on the server side of KMS.
pkg/crypto/tinkcrypto/primitive/cl/signer/cl_signer_key_manager.go
Outdated
Show resolved
Hide resolved
kgoncharov
force-pushed
the
cl-crypto-api-tink
branch
2 times, most recently
from
5267cef
to
a27d8e9
Compare
kgoncharov
force-pushed
the
cl-crypto-api-tink
branch
from
a27d8e9
to
780f7c1
Compare
* extended Crypto API with SignWithSecrets and Blind methods * refactored CL primitives * implemented new methods for tinkcrypto * formatted all ursa code * added ursautil for common ursa methods * added stubs for CL for remotecrypto and non-ursa tinkcrypto build * added unit tests Signed-off-by: konstantin.goncharov <konstantin.goncharov@avast.com>
kgoncharov
force-pushed
the
cl-crypto-api-tink
branch
from
780f7c1
to
ab829fe
Compare
Title:
CL Anoncreds Crypto API
Description:
af-go#180tinkcrypto)tinkcryptoremotecryptochanges will be introduced in the one of the latest PRsSummary:
libursaCL primitives fortinkcryptoimplementationursaCL verifier functionalityremotecryptoandtinkcryptofor the case where noursainstalled