Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

feat: Connection protocol (RFC-0160) DIDCommV1 implementation #3295

Merged

Conversation

Abdulbois
Copy link
Contributor

@Abdulbois Abdulbois commented Jul 25, 2022

Title:
Connection protocol (RFC-0160) DIDCommV1 implementation

Summary:

  • On this PR only part related to protocol package is implemented (client part is not implemented yet)
  • Enable to handle "did:key" keys while creating legacy forwards.
  • Add legacy profile types and use them while checking transport types.

closes #3299

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #3295 (9912a68) into main (1daefcc) will decrease coverage by 0.01%.
The diff coverage is 87.48%.

@@            Coverage Diff             @@
##             main    #3295      +/-   ##
==========================================
- Coverage   88.05%   88.04%   -0.02%     
==========================================
  Files         318      322       +4     
  Lines       43156    44329    +1173     
==========================================
+ Hits        38002    39028    +1026     
- Misses       3799     3906     +107     
- Partials     1355     1395      +40     
Impacted Files Coverage Δ
pkg/didcomm/protocol/legacyconnection/service.go 86.59% <86.59%> (ø)
pkg/didcomm/protocol/legacyconnection/states.go 87.45% <87.45%> (ø)
pkg/didcomm/protocol/legacyconnection/keys.go 88.67% <88.67%> (ø)
pkg/didcomm/dispatcher/outbound/outbound.go 91.04% <100.00%> (+0.15%) ⬆️
pkg/didcomm/packager/packager.go 89.88% <100.00%> (ø)
pkg/didcomm/protocol/legacyconnection/event.go 100.00% <100.00%> (ø)
pkg/doc/util/kmsdidkey/kmsdidkey.go 90.32% <100.00%> (+0.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Abdulbois Abdulbois force-pushed the connection-protocol branch 2 times, most recently from 552866d to 3d01a16 Compare July 25, 2022 13:24
@sudeshrshetty
Copy link
Contributor

sudeshrshetty commented Jul 25, 2022

@Abdulbois can you please create an aries issue with details and mention that issue number in this PR?

also, sign off your commit as per guidelines

@Abdulbois Abdulbois force-pushed the connection-protocol branch 13 times, most recently from 8293d14 to cbdbe29 Compare August 9, 2022 11:49
…lly)

- Add implementation only for protocol's package
- Enable to handle "did:key" keys while creating legacy forwards.
- Add legacy profile types and use them while checking transport types.

Signed-off-by: Abdulbois <abdulbois.tursunov@avast.com>
@sudeshrshetty sudeshrshetty merged commit adc27a6 into hyperledger-archives:main Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Connection Protocol RFC-0160
3 participants