Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

fix: credential manifest omit optional properties #3336

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

HeidiHan0000
Copy link
Contributor

Closes #3335

Summary:

  • omitempty tag for mandatory properties were removed
  • optional properties (with the omitempty tag) of custom types were changed to pointers so they can be omitted with the omitempty tag
  • additional validation checks which were missing and more unit tests

@HeidiHan0000 HeidiHan0000 force-pushed the issue-3335 branch 2 times, most recently from 6e1294f to 5a879f0 Compare August 15, 2022 13:42
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #3336 (2ac545b) into main (e5f18f2) will increase coverage by 0.00%.
The diff coverage is 95.58%.

❗ Current head 2ac545b differs from pull request most recent head 4a716b1. Consider uploading reports for the commit 4a716b1 to get more accurate results

@@           Coverage Diff           @@
##             main    #3336   +/-   ##
=======================================
  Coverage   88.04%   88.05%           
=======================================
  Files         327      327           
  Lines       45178    45221   +43     
=======================================
+ Hits        39779    39819   +40     
- Misses       3985     3987    +2     
- Partials     1414     1415    +1     
Impacted Files Coverage Δ
pkg/doc/cm/credentialfulfillment.go 86.36% <ø> (ø)
pkg/doc/cm/credentialmanifest.go 92.52% <94.91%> (-0.07%) ⬇️
pkg/doc/cm/credentialapplication.go 92.80% <100.00%> (+0.11%) ⬆️
pkg/doc/cm/resolve.go 90.96% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pkg/doc/cm/credentialmanifest.go Outdated Show resolved Hide resolved
Signed-off-by: heidihan0000 <daeun.han@avast.com>
@fqutishat fqutishat merged commit 5fa4db1 into hyperledger-archives:main Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Optional credential manifest fields are not omitted
3 participants