This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: wallet Prove supports creating JWT presentations. #3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3350 +/- ##
==========================================
+ Coverage 87.84% 87.86% +0.01%
==========================================
Files 330 330
Lines 45633 45691 +58
==========================================
+ Hits 40087 40145 +58
Misses 4110 4110
Partials 1436 1436
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Moopli
force-pushed
the
jwt-prove
branch
4 times, most recently
from
cd6df9a
to
825b836
Compare
| return nil, fmt.Errorf("failed to prove credentials: %w", err) | ||
| switch proofOptions.ProofFormat { | ||
| case ExternalJWTProofFormat: | ||
| // TODO: look into passing audience identifier |
There was a problem hiding this comment.
can you please create a task for this TODO in aries, so that we don't miss it.
There was a problem hiding this comment.
@sudeshrshetty good idea, done: #3354
sudeshrshetty
approved these changes
Aug 29, 2022
Signed-off-by: Filip Burlacu <filip.burlacu@securekey.com>
fqutishat
approved these changes
Aug 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Filip Burlacu filip.burlacu@securekey.com