This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: presentation definition can match array of presentations #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO add tests:
|
sandrask
reviewed
Feb 27, 2023
pkg/doc/presexch/api.go
Outdated
| @@ -76,70 +81,75 @@ func WithDisableSchemaValidation() MatchOption { | |||
| } | |||
|
|
|||
| // Match returns the credentials matched against the InputDescriptors ids. | |||
| func (pd *PresentationDefinition) Match(vp *verifiable.Presentation, // nolint:gocyclo,funlen | |||
| contextLoader ld.DocumentLoader, options ...MatchOption) (map[string]*verifiable.Credential, error) { | |||
| func (pd *PresentationDefinition) Match(vpList []*verifiable.Presentation, // nolint:gocyclo,funlen | |||
There was a problem hiding this comment.
Match interface looks good to me.
Moopli
force-pushed
the
pd-multi-vp
branch
2 times, most recently
from
c9838a0
to
89772e1
Compare
Codecov Report
@@ Coverage Diff @@
## main #3538 +/- ##
==========================================
+ Coverage 87.72% 87.75% +0.03%
==========================================
Files 351 351
Lines 48423 48511 +88
==========================================
+ Hits 42481 42573 +92
+ Misses 4402 4398 -4
Partials 1540 1540
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Filip Burlacu <filip.burlacu@securekey.com>
sandrask
approved these changes
Mar 3, 2023
rolsonquadras
requested review from
vkubiv,
sudeshrshetty,
DRK3 and
rolsonquadras
vkubiv
approved these changes
Mar 3, 2023
sudeshrshetty
approved these changes
Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Filip Burlacu filip.burlacu@securekey.com