This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
refactor: disabled JSON-LD checks for VPs with JWT VCs by default #3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkubiv
approved these changes
Feb 28, 2023
Moopli
reviewed
Feb 28, 2023
Moopli
reviewed
Feb 28, 2023
DRK3
reviewed
Feb 28, 2023
Signed-off-by: Anton Biriukov <anton.biriukov@avast.com>
birtony
requested review from
Moopli and
DRK3
and removed request for
rolsonquadras,
sudeshrshetty,
Moopli and
DRK3
Codecov Report
@@ Coverage Diff @@
## main #3540 +/- ##
=======================================
Coverage 87.72% 87.72%
=======================================
Files 351 351
Lines 48416 48423 +7
=======================================
+ Hits 42471 42481 +10
+ Misses 4404 4402 -2
+ Partials 1541 1540 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Moopli
approved these changes
Feb 28, 2023
| @@ -402,6 +403,14 @@ func WithPresJSONLDDocumentLoader(documentLoader jsonld.DocumentLoader) Presenta | |||
| } | |||
| } | |||
|
|
|||
| // WithDisabledJSONLDChecks disables JSON-LD checks for VP parsing. | |||
| // By default, JSON-LD checks are enabled. | |||
| func WithDisabledJSONLDChecks() PresentationOpt { | |||
There was a problem hiding this comment.
Please specify in comments atleast, what you mean by JSON LD checks, is it JSON LD Schema Validation?
sudeshrshetty
approved these changes
Feb 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anton Biriukov anton.biriukov@avast.com