This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: SDJWT V5 (#33) #3617
Merged
feat: SDJWT V5 (#33) #3617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3617 +/- ##
==========================================
+ Coverage 86.90% 86.94% +0.04%
==========================================
Files 362 367 +5
Lines 49360 50011 +651
==========================================
+ Hits 42895 43481 +586
- Misses 4899 4945 +46
- Partials 1566 1585 +19
|
mishasizov-SK
force-pushed
the
feat_sdjwt_v5
branch
6 times, most recently
from
0bbf6ad
to
540ee6b
Compare
mishasizov-SK
commented
Aug 9, 2023
| } | ||
|
|
||
| // discloseClaimValue returns new value of claim, resolving dependencies on other disclosures. | ||
| func discloseClaimValue(claim interface{}, recData *recursiveData) (interface{}, error) { // nolint:funlen,gocyclo |
There was a problem hiding this comment.
discloseClaimValue is the root function of this patch.
It responsible for:
- resolving recursive digests in disclosures.
- resolving digests in incoming claims.
also, it does a basic checks, e.g.
- claim key duplications on the same nesting level
- digests duplications
- disclosure elements length (2 elems for array digest, 3 elems for sd digest).
Rest validation is done on the funcs that calls discloseClaimValue
Signed-off-by: Mykhailo Sizov <mykhailo.sizov@securekey.com> feat: improve coverage fix: nil feat: more coverage
fqutishat
approved these changes
Aug 10, 2023
rolsonquadras
approved these changes
Aug 10, 2023
sudeshrshetty
approved these changes
Aug 10, 2023
sudeshrshetty
merged commit 71e132b
into
hyperledger-archives:main
12 of 14 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
SD JWT V5 Support
Description:
https://www.ietf.org/archive/id/draft-ietf-oauth-selective-disclosure-jwt-02.html
https://www.ietf.org/archive/id/draft-ietf-oauth-selective-disclosure-jwt-05.html
Summary: