This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: Improvements to ECDSA2019 DI API #3618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRK3
force-pushed
the
ECDSA2019DIImprovements
branch
from
d99960f
to
8001351
Compare
DRK3
changed the title
DRK3
changed the title
The existing API required an interface that defines many more methods than what are actually required, which forces consumers of the API to implement many methods that won't ever be called. The API has now been changed to make use of two minimal interfaces instead, making it easier to use and understand. Note that implementations of the larger crypto interface can still be used since the minimal interface method signatures match. To avoid potential confusion with the new interface names, two existing constructors were renamed. Signed-off-by: Derek Trider <derek.trider@gendigital.com>
DRK3
force-pushed
the
ECDSA2019DIImprovements
branch
from
8001351
to
a1a50c4
Compare
Codecov Report
@@ Coverage Diff @@
## main #3618 +/- ##
==========================================
- Coverage 86.94% 86.94% -0.01%
==========================================
Files 367 367
Lines 50011 50020 +9
==========================================
+ Hits 43484 43490 +6
- Misses 4943 4945 +2
- Partials 1584 1585 +1
|
vkubiv
approved these changes
Aug 15, 2023
rolsonquadras
approved these changes
Aug 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing API required an interface that defines many more methods than what are actually required, which forces consumers of the API to implement many methods that won't ever be called. The API has now been changed to make use of two minimal interfaces instead, making it easier to use and understand. Note that implementations of the larger crypto interface can still be used since the minimal interface method signatures match.
To avoid potential confusion with the new interface names, two existing constructors were renamed.