This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: Webhook notifier now sends JSON #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #523 +/- ##
==========================================
+ Coverage 90.07% 90.61% +0.53%
==========================================
Files 77 77
Lines 4020 3973 -47
==========================================
- Hits 3621 3600 -21
+ Misses 222 204 -18
+ Partials 177 169 -8
Continue to review full report at Codecov.
|
DRK3
force-pushed
the
webhookSupplyRealData-472
branch
6 times, most recently
from
ac1256f
to
29450d4
Compare
|
Rolson suggested adding the actual structs for the various JSON messages, so I'm doing that now. |
DRK3
force-pushed
the
webhookSupplyRealData-472
branch
5 times, most recently
from
73482cc
to
c27b941
Compare
DRK3
force-pushed
the
webhookSupplyRealData-472
branch
2 times, most recently
from
91257df
to
2934294
Compare
DRK3
force-pushed
the
webhookSupplyRealData-472
branch
5 times, most recently
from
6668573
to
b098589
Compare
Webhook notifier now sends arbitrary JSON messages. The ticker was removed. Signed-off-by: Derek Trider <derek.trider@securekey.com>
DRK3
force-pushed
the
webhookSupplyRealData-472
branch
from
b098589
to
329ced1
Compare
sudeshrshetty
approved these changes
Oct 22, 2019
rolsonquadras
approved these changes
Oct 22, 2019
fqutishat
approved these changes
Oct 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #472
Webhook notifier now sends arbitrary JSON messages. The ticker was removed.
The actual triggering of webhook notifications has to be done in another story since the REST Api is still in-progress.
Signed-off-by: Derek Trider derek.trider@securekey.com