This repository has been archived by the owner on May 13, 2022. It is now read-only.
Fix unstable genesis hash between v0.30.0 and v0.31.0 #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasdavis
force-pushed
the
genesis-stability
branch
from
8a8525e
to
8d92ac5
Compare
This was due to accidental removaal of `omitempty` from AppHash. Also: - Add simple genesis stability snapshot test - Treat `GenesisDoc.ChainID` as read only and re-introduce `GenesisDoc.chainID` as lazy memo storage for ChainID to avoid writing back a chainID which was generated and never present in verbatim gendoc Signed-off-by: Silas Davis <silas@monax.io>
silasdavis
force-pushed
the
genesis-stability
branch
from
8d92ac5
to
a1b8ac2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was due to accidental removaal of
omitemptyfrom AppHash.Also:
GenesisDoc.ChainIDas read only and re-introduceGenesisDoc.chainIDas lazy memo storage for ChainID to avoid writingback a chainID which was generated and never present in verbatim gendoc
Signed-off-by: Silas Davis silas@monax.io