This repository has been archived by the owner on May 13, 2022. It is now read-only.
Fix collisions in ABI output, submit contract metadata on deploy, remove GRPC dependencies from codegen interface.gd.ts #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasdavis
changed the title
GRPC dependencies from codegen interface.gd.ts - Switched to a hierarchical bin folder to only require contract names to be unique within their own directory - Send contract ABIs to Burrow from codegen deploy function - Remove dependency on GRPC types to improve ergonomics and not couple GRPC codegen to the provider interface hopefully to give better compatibility between versions - Use duck-typed interface for CancelStreamSignal so that cancel signal is not path dependent (for compatibiltiy between multiple Burrow versions where possible in same project) Signed-off-by: Silas Davis <silas@monax.io>
silasdavis
force-pushed
the
solts
branch
4 times, most recently
from
5885ea4
to
4b4d423
Compare
Signed-off-by: Silas Davis <silas@monax.io>
silasdavis
force-pushed
the
solts
branch
2 times, most recently
from
87a3a64
to
824d331
Compare
Signed-off-by: Silas Davis <silas@monax.io>
Signed-off-by: Silas Davis <silas@monax.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be unique within their own directory
GRPC codegen to the provider interface hopefully to give better
compatibility between versions
is not path dependent (for compatibiltiy between multiple Burrow
versions where possible in same project)
Signed-off-by: Silas Davis silas@monax.io