Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

Adding the letters of credit sample app (again) #139

Merged
merged 2 commits into from
May 31, 2018

Conversation

erin-hughes
Copy link
Contributor

Hopefully addressed the DCO issue

Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com>

Updating to final bank names (#45)

Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com>

Implemented alert for when Bob's balance increases

Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com>

First wave of css tweaks

Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com>

Second wave of css changes

Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com>

Further styling changes, addition of status bar, bug fixes

Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com>

Swapping currencies and exchange rates

Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com>

Tutorial updates from feedback (#52)

* tutorial contents

Signed-off-by: awjh-ibm <andrew.hurt1@ibm.com>

* updating tutorial against feedback

Signed-off-by: awjh-ibm <andrew.hurt1@ibm.com>

Updating IBAN to refelct change in countries (#53)

Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com>

update installer ready for release (#54)

Signed-off-by: awjh-ibm <andrew.hurt1@ibm.com>

Allow network version changing in installer (#55)

* allow for network version change

Signed-off-by: awjh-ibm <andrew.hurt1@ibm.com>

* acme -> example

Signed-off-by: awjh-ibm <andrew.hurt1@ibm.com>
@awjh-ibm awjh-ibm self-requested a review May 31, 2018 12:27

# REMOVE EXISTING REST SERVER, PLAYGROUND ETC
docker rm -f $(docker ps -a | grep hyperledger/* | awk '{ print $1 }')
docker rm -f $(docker ps -a | grep awjh/* | awk '{ print $1 }')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awjh is no longer used for docker so line should be removed

docker pull hyperledger/composer-playground:latest
docker pull hyperledger/composer-cli:latest
docker pull hyperledger/composer-rest-server:latest
docker pull awjh/letters-of-credit:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should pull from hyperledger not awjh

Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com>
Copy link
Contributor

@awjh-ibm awjh-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🎉 👏

@awjh-ibm awjh-ibm merged commit 6916021 into hyperledger-archives:master May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants