This repository has been archived by the owner on Mar 8, 2020. It is now read-only.
Properly explain what is "getting-started" in main README and correct 'info.js' instruction #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 16, 2017 17:23
If a user comes straight to the Digital Property app and runs, what is, an OPTIONAL step to see info about all the Sample Applications in the repo, then npm install must be run (at sample-applications level) before running the 'node info.js' step. Put in the word OPTIONAL, because they user can skip the step and go straight to deploying the sample digital property app. Also, the node info steps should be added back to the main README for sample-applications (will do so next)
Added that Digital Property app is the 'getting-started' app (otherwise not that clear) and also add in the 'info.js' instruction which was buried in digitalproperty-app previously (but belongs here)
nklincoln
approved these changes
Aug 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain that Digital Property app is the 'getting-started' app and correctly explain the instruction for 'info.js' as being in the 'main sample-applications' README file, where previously it was only explained deep in the README for digitalproperty-app. Still described there too - but as an OPTIONAL step, if someone had come 'straight' to that sample app directory, directly and was following the instructions on cloning the sample-applications repository.
This PR relates to https://github.com/hyperledger/composer-sample-applications/issues/72 and also https://github.com/hyperledger/composer-sample-applications/issues/78 following 'tidy-up' of 0.6 instructions.