This repository has been archived by the owner on Dec 2, 2021. It is now read-only.
FAB-16727 Fix address case sensitivity #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses can now be matched regardless of case in parsing logs. Signed-off-by: Darian Plumb <dplumb@bitwise.io>
dplumb94
requested review from
christo4ferris,
guoger,
mastersingh24,
MHBauer,
muralisrini and
swetharepakula
as code owners
|
This PR was done as part of an exercise in Hyperledger Maintainer Summit. Tests will be added afterwards |
|
@MHBauer do we still care about change id? I am thinking since we don't need it since we have branches on github |
|
changeID is purely a gerrit thing. with switch to github PRs, there is no need for changeID. We should all probably take the gerrit pre-commit hooks out of our repos. |
MHBauer
suggested changes
Oct 8, 2019
| @@ -727,7 +727,7 @@ LOG_EVENT: | |||
| // if no address, empty range, skipped, present but empty address field results in no match | |||
| for _, address := range af { | |||
| logger.Debugw("trying address match", "matcherAddress", address, "eventAddress", logEvent.Address) | |||
| if logEvent.Address == address { | |||
There was a problem hiding this comment.
should probably do this once on the way in rather than inside a double for loop.
|
I will take over this change. Spoke with @dplumb94 offline to confirm. |
|
Closing in favor of #18 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses can now be matched regardless of case in parsing logs.
Signed-off-by: Darian Plumb dplumb@bitwise.io
Thank you for contributing to the
fabric-chaincode-evmproject!Please look at our Contributions Docs and make
sure you have done the following before submitting:
make basic-checksmake unit-testmake integration-testIf you do not have a corresponding JIRA ticket, please open one in the Fabric
JIRA and add
fabric-chaincode-evmas the component. In the JIRA ticket, include usecases, design and other information useful to understanding why you are making
this pull request.
If you have any questions please feel free to ask in the #fabric-evm channel
on the Hyperledger Chat.
Thanks again for your contribution!