Run CI with go 1.13.15 #37
base: main
Are you sure you want to change the base?
Run CI with go 1.13.15 #37
Conversation
d6f8e66
to
516b780
Compare
- use fabric `release-1.4` branch to pull in fix for nexus repo change required to build fabric components Signed-off-by: Swetha Repakula <swetha.repakula@gmail.com>
b19d403
to
ccc26e2
Compare
Signed-off-by: Swetha Repakula <swetha.repakula@gmail.com>
ccc26e2
to
4ec02be
Compare
Definitely confusing for the integration tests. I see
but above that it prints out that image
Rumor was it worked locally? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much fine. Nits only if you want to address.
Not sure how to get the integration working from a quick look.
@@ -73,6 +73,7 @@ var _ = SynchronizedBeforeSuite(func() []byte { | |||
By("setting up the channel") | |||
network.CreateAndJoinChannel(orderer, channelName) | |||
network.UpdateChannelAnchors(orderer, channelName) | |||
network.EventuallyTimeout = 2 * time.Minute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bigger timeouts? Things going slower?
echo "Please switch Fabric Repository to tag v1.4.0 before running these tests" | ||
FABRIC_VERSION=$(git -C ${FABRIC_DIR} rev-parse --abbrev-ref HEAD) | ||
if [[ ${FABRIC_VERSION} != "release-1.4" ]]; then | ||
echo "Please switch Fabric Repository to release v1.4.0 before running these tests, it currently is on ${FABRIC_VERSION}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have to match exactly the branch name?
If so, the echo Error message should update to say "branch relaese-1.4".
pr: | ||
- master | ||
- main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest pulling this out into a spearate pr, but we're probably in a broken state until it gets done.
Add a Comment in the commit message.
Need a follow up issue, for revising the documentation where the default branch name shows up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like #36 does most of that
Oh, I see, this is a stack on #38 |
@@ -53,6 +53,7 @@ main() { | |||
make ccenv CHAINTOOL_URL='https://hyperledger.jfrog.io/hyperledger/fabric-maven/org/hyperledger/fabric-chaintool/$(CHAINTOOL_RELEASE)/fabric-chaintool-$(CHAINTOOL_RELEASE).jar' | |||
popd | |||
|
|||
echo "$(docker images)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, good output.
No description provided.