This repository has been archived by the owner on Feb 29, 2024. It is now read-only.
Various fixes in getting started guide and docstrings [skip ci] #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skhoroshavin
changed the title
skhoroshavin
changed the title
skhoroshavin
force-pushed
the
getting_started_fixes
branch
from
d66bd36
to
7055317
Compare
skhoroshavin
changed the title
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
skhoroshavin
force-pushed
the
getting_started_fixes
branch
from
7055317
to
f7963e3
Compare
added 2 commits
March 1, 2018 13:44
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
skhoroshavin
changed the title
Signed-off-by: Sergey Khoroshavin <sergey.khoroshavin@dsr-corporation.com>
|
Concerning commit 7c9f5b8: after looking through the rest of notebook I'm not sure if this change is good - it just might be better to rename few _verkey variables to _keys. The main reason for this change is that I felt it misleading to have the very same data (although from different sources) in variables those naming is quite different semantically. Feedback is very welcome. Also it might be better to refactor onboarding function into different parts to separate actors better, but this is out of scope of this PR, I'm going to open an issue to discuss this. |
skhoroshavin
changed the title
jovfer
approved these changes
Mar 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Khoroshavin sergey.khoroshavin@dsr-corporation.com