This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Add feature for custom genesis block gen #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kitsu <mail@kitsu.me>
l4l
added
needs-review
l4l
requested review from
Alexey-N-Chernyshov and
grimadas
and removed request for
Alexey-N-Chernyshov
grimadas
reviewed
Apr 16, 2018
iroha-cli/main.cpp
Outdated
| logger->error("--peers_address is empty"); | ||
| return EXIT_FAILURE; | ||
| iroha::model::Transaction transaction; | ||
| if (FLAGS_genesis_transaction == "") { |
grimadas
reviewed
Apr 16, 2018
iroha-cli/main.cpp
Outdated
| @@ -55,6 +57,9 @@ DEFINE_string(json_query, "", "Query in json format"); | |||
| DEFINE_bool(genesis_block, | |||
| false, | |||
| "Generate genesis block for new Iroha network"); | |||
| DEFINE_string(genesis_transaction, | |||
| "", | |||
| "File with transaction in json format for the genesis"); | |||
Alexey-N-Chernyshov
approved these changes
Apr 16, 2018
Signed-off-by: Kitsu <mail@kitsu.me>
grimadas
approved these changes
Apr 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Allow transaction loading for genesis block generation in cli. I know it is going to be rewritten but that small fix enable that vial feature.
Benefits
Configuration of the genesis block
Usage Examples or Tests [optional]
iroha-cli --genesis_block --genesis_transaction <your_file>