-
Notifications
You must be signed in to change notification settings - Fork 297
Use pubkey as identifier in SignatureSetType #1193
Conversation
Signed-off-by: Eugene Minibaev <mail@kitsu.me>
This fix should contain test with text data based on modified version of ed25519 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall but I agree with @neewy that we need some tests for this issue.
It is not really trivial to write the test for that case, as long as:
|
@l4l What kind of timeout check do you mean? It should be possible to create a transaction with |
Good idea |
Signed-off-by: Kitsu <mail@kitsu.me>
Any progress? I've noticed you have added test in commit above, is it sufficient to review this fix? |
Yes, for now only that test can be done without significant projects changes and I think better review&merge it asap, then think about other components (though, they will work as well, as they have code duplication actually) |
Signed-off-by: Kitsu <mail@kitsu.me>
Signed-off-by: Kitsu <mail@kitsu.me>
Description of the Change
ed25519 can have different signature for the same public key, so it necessary to guarantee uniqueness of each public key in signature set